Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support no-op replication for remote-backed indexes #5731

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jan 6, 2023

Description

This PR combines following PRs to backport to 2.x -

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…d replica (opensearch-project#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ect#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

…dices (opensearch-project#5616)

Add transport action for primary term validation for remote-backed indices

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 changed the title [Backport 2.x] Add transport action for primary term validation for remote-backed indices (#5616) [Backport 2.x] Support no-op replication for remote-backed indexes Jan 9, 2023
@gbbafna gbbafna merged commit 6eca25f into opensearch-project:2.x Jan 9, 2023
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Jan 10, 2023
…pensearch-project#5731)

* Remove PRRL creation/deletion in peer recovery of remote store enabled replica (opensearch-project#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Enhance CheckpointState to support no-op replication (opensearch-project#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add transport action for primary term validation for remote-backed indices (opensearch-project#5616)

Add transport action for primary term validation for remote-backed indices

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>
gbbafna pushed a commit that referenced this pull request Jan 10, 2023
* Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Enhance CheckpointState to support no-op replication (#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add transport action for primary term validation for remote-backed indices (#5616)

Add transport action for primary term validation for remote-backed indices

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Ashish <ssashish@amazon.com>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…5731)

* Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Enhance CheckpointState to support no-op replication (#5282)

* CheckpointState enhanced to support no-op replication

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Bukhtawar Khan<bukhtawa@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add transport action for primary term validation for remote-backed indices (#5616)

Add transport action for primary term validation for remote-backed indices

Signed-off-by: Ashish Singh <ssashish@amazon.com>

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants